- Global cfl_njl_eos::calc_eq_temp_p (quark &u, quark &d, quark &s, double &qq1, double &qq2, double &qq3, double &gap1, double &gap2, double &gap3, double mu3, double mu8, double &n3, double &n8, thermo &qb, double temper)
- It surprises me that n3 is not -res[11]. Is there a sign error in the color densities?
- Global cfl_njl_eos::gapped_eigenvalues (double m1, double m2, double lmom, double mu1, double mu2, double tdelta, double lam[4], double dldmu1[4], double dldmu2[4], double dldm1[4], double dldm2[4], double dldg[4])
- In the code, the equal mass case seems to be commented out. Why?
- Global ddc_eos::calc_eq_e (fermion &neu, fermion &p, double sig, double ome, double rho, double &f1, double &f2, double &f3, thermo &th)
- Is the thermodynamic identity is satisfied even when the field equations are not solved? Check this.
- Class gen_sn_eos
Ensure all chemical potentials are based on the same rest masses?
Allow logarithmic grids for any of nb, Ye, or T.
- Class ldrop_mass_skin
This is based on LPRL, but it's a little different in Lattimer and Swesty. I should document what the difference is.
The testing could be updated.
- Class ls_eos
- There are still a few points for which the electron/photon EOS seems to be off.
- Class rmf_eos
- The functions fcomp_fields(), fkprime_fields(), and fesym_fields() are not quite correct if the neutron and proton masses are different. For this reason, they are currently unused by saturation().
- The fix_saturation() and calc_cr() functions use mnuc, and should be modified to allow different neutron and proton masses.
- Check the formulas in the "Background" section
- There are two calc_e() functions that solve. One is specially designed to work without a good initial guess. Possibly the other calc_e() function should be similarly designed?
- Make sure that this class properly handles particles for which inc_rest_mass is true/false
- The error handler is called sometimes when calc_e() is used to compute pure neutron matter. This should be fixed.
- Decide whether to throw an error at [Ref. 1].
- Put the err_nonconv system into calc_p(), calc_temp_e() and fix_saturation(), etc.
- Global rmf_eos::check_naturalness (rmf_eos &re)
- I may have ignored some signs in the above, which are unimportant for this application, but it would be good to fix them for posterity.
- Global rmf_eos::fix_saturation (double guess_cs=4.0, double guess_cw=3.0, double guess_b=0.001, double guess_c=-0.001)
- Fix this for zm_mode=true
- Ensure solver is more robust
- Global rmf_eos::fkprime_fields (double sig, double ome, double nb, double &k, double &kprime)
- Does this work? Fix fkprime_fields() if it does not.
- Global rmf_eos::n_charge
- Should use hadronic_eos::proton_frac instead?
- Class rmf_nucleus
Better documentation
Convert energies() to use EOS and possibly replace sigma_rhs() and related functions by the associated field equation method of rmf_eos.
Document hw=3.923+23.265/cbrt(atot);
- Global schematic_eos::set_a_from_mstar (double u_msom, double mnuc)
- This was computed in schematic_sym.nb, which might be added to the documentation?
- Class sht_eos
- More documentation
- Class skyrme_eos
- Make sure that this class properly handles particles for which inc_rest_mass is true/false
- What about the spin-orbit units?
- Need to write a function that calculates saturation density?
- Remove use of mnuc in calparfun()?
- The compressibility could probably use some simplification
- Make sure the finite-temperature part is properly tested
- The testing code doesn't work if err_mode is 2, probably because of problems in load().
- Document load() file format.
- Update reference list.
- Global skyrme_eos::calpar (double gt0=-10.0, double gt3=70.0, double galpha=0.2, double gt1=2.0, double gt2=-1.0)
Does this work for both 'a' and 'b' non-zero?
Compare to similar formulae from Margueron02
- Global skyrme_eos::landau_neutron (double n0, double m, double &f0, double &g0, double &f1, double &g1)
- This needs to be checked
- Global skyrme_eos::landau_nuclear (double n0, double m, double &f0, double &g0, double &f0p, double &g0p, double &f1, double &g1, double &f1p, double &g1p)
- This needs to be checked.
- Class tov_eos
- Fix read_table_file and maybe set_low_density_eos().
- Class tov_interp_eos
Warn that the pressure in the low-density eos is not strictly increasing! (see at P=4.3e-10)
It might be useful to exit more gracefully when non-finite values are obtained in interpolation, analogous to the err_nonconv mechanism elsewhere.
- Class tov_solve
- baryon mass doesn't work for fixed() (This may be fixed. We should make sure it's tested.)
- Combine maxoutsize and kmax?
- Document column naming issues
- Document surface gravity and redshift
- Standardize
xmev_kg
, etc.
- Use convert_units?
- Double check that fixed() doesn't give a solution on the unstable branch
- Ensure that this class copies over the units of the user-specified columns to the table